Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper styling for App Switcher with one entity #2466

Merged
merged 8 commits into from
Jan 13, 2022
Merged

Proper styling for App Switcher with one entity #2466

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e50144a
Add poossibility t have 1 item inside f AppSwitcher and fix the bug w…
UlianaMunich Dec 28, 2021
cf6227b
revert typ fix for getSAPIconStr function
UlianaMunich Dec 28, 2021
5efad7b
Merge branch 'master' into 2408-dropdown-single-app-bug
stanleychh Dec 29, 2021
ef7ce5c
Merge branch 'master' into 2408-dropdown-single-app-bug
stanleychh Jan 10, 2022
084f53a
Rename TopNav.html into TopNav.svelte
UlianaMunich Jan 13, 2022
2410d80
Merge branch '2408-dropdown-single-app-bug' of github.com:UlianaMunic…
UlianaMunich Jan 13, 2022
ee4389a
Merge confllicts due to renaming of html files into .svelte
UlianaMunich Jan 13, 2022
ca83031
return lost changes for the single App Switcher
UlianaMunich Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions core/src/navigation/LogoTitle.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,17 @@
{/if}{:else}
<div class="fd-popover">
<div class="fd-popover__control" on:click|stopPropagation="{() => {}}">
{#if addNavHrefForAnchor} {#if appSwitcherItems && appSwitcherItems.length > 0} {#each
appSwitcherItems as item} {#if item === selectedItem && hasValidLink(item,
pathParams)}
{#if addNavHrefForAnchor} {#if appSwitcherItems && appSwitcherItems.length === 1}
<a
href="{getRouteLink(appSwitcherItems[0])}"
class="fd-shellbar__title lui-shellbar-single-app-title"
>
<span>
{$getTranslation(appSwitcherItems[0].title)}
</span>
</a>
{/if} {#if appSwitcherItems && appSwitcherItems.length > 1} {#each appSwitcherItems as
item} {#if item === selectedItem && hasValidLink(item, pathParams)}
<a
href="{getRouteLink(item)}"
class="fd-button fd-button--transparent fd-button--menu fd-shellbar__button--menu lui-app-switch"
Expand All @@ -59,7 +67,7 @@
>
<i class="sap-icon sap-icon--megamenu fd-shellbar__button--icon"></i>
</a>
{/if} {/each} {/if} {#if appSwitcherItems.length > 0 && !selectedItem}
{/if} {/each} {/if} {#if appSwitcherItems.length > 1 && !selectedItem}
<a
href="/"
class="fd-button fd-button--transparent fd-button--menu fd-shellbar__button--menu lui-app-switch"
Expand Down