Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - getCoreSearchParams should not return undefined #2475

Merged

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Jan 12, 2022

Fixes #2473
How to reproduce

Example config for simpledev:

{
              pathSegment: 'home2', 
              label: 'h2', 
              hideFromNav: false, 
              children: [
                {
                
                  pathSegment:'test',
                  label:'test',
                  loadingIndicator: {
                      enabled: false
                  },
                  viewUrl: 'microfrontend.html',
                  clientPermissions:{
                    urlParameters:{
                      q:{
                        write: true,
                        read: true
                      }
                    }
                  }
                },
                {
                  pathSegment:'test2',
                  label:'test2',
                  loadingIndicator: {
                      enabled: false
                  },
                  viewUrl: 'microfrontend2.html'
                }
              ]
          }
  • navigate without sync from test to test2
    LuigiClient.linkManager().withoutSync().navigate('/home2/test2')
  • LuigiClient.getCoreSearchParams() should return an empty object instead of undefined

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Jan 12, 2022
@JohannesDoberer JohannesDoberer changed the title bug fix Fix - getCoreSearchParams should not return undefined Jan 17, 2022
@JohannesDoberer JohannesDoberer marked this pull request as ready for review January 17, 2022 12:19
@ndricimrr ndricimrr self-assigned this Jan 17, 2022
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected 👍

@JohannesDoberer JohannesDoberer merged commit 4534264 into master Jan 21, 2022
@JohannesDoberer JohannesDoberer deleted the Fix-getCoreSearchParams-should-not-return-undefined branch January 21, 2022 09:45
@JohannesDoberer JohannesDoberer mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getCoreSearchParams returns sometimes undefined
2 participants