Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function which allow to get the footer container #2488

Merged
merged 14 commits into from
Jan 31, 2022
Merged

Add function which allow to get the footer container #2488

merged 14 commits into from
Jan 31, 2022

Conversation

UlianaMunich
Copy link
Contributor

Fixes #2321

Test it in the console of the browser:

var span = document.createElement("span");
span.innerHTML='simpleTest';
Luigi.elements().getNavFooterContainer().append(span);

Result: a new simpeTest is added after a footer Text (Luigi version x.x.x)

@JohannesDoberer JohannesDoberer self-assigned this Jan 21, 2022
@stanleychh
Copy link
Contributor

@UlianaMunich, the LeftNav.html already converted to LeftNav.svelte. Please let me know if you need help on solving conflict. Thanks.

JohannesDoberer
JohannesDoberer reviewed Jan 28, 2022
View reviewed changes
test/e2e-test-application/e2e/tests/0-fiddle/fiddle-navigation.spec.js Outdated
@@ -905,4 +905,37 @@ describe('Fiddle', () => {
cy.get('.lui-nav-title .fd-nested-list__title').should('contain', 'test');
});
});

describe('Custom text in the footer', () => {
context('Desktop', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually no need to define a 'desktop context' if there is no other context distinction.

JohannesDoberer
JohannesDoberer approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UlianaMunich UlianaMunich merged commit d943f7c into SAP:master Jan 31, 2022
@UlianaMunich UlianaMunich deleted the 2321-footer-container-function branch January 31, 2022 09:35
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Apr 6, 2022
@ndricimrr ndricimrr mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

@stanleychh stanleychh Awaiting requested review from stanleychh

@wdoberschuetz wdoberschuetz Awaiting requested review from wdoberschuetz

Assignees

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow HTML in sideNavFooterText OR make it a function
4 participants
@UlianaMunich @stanleychh @JohannesDoberer @alexandra-simeonova