preserveView should allow viewUrls with query params #250
+88
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
parostatkiem-zz,
pekura and
y-kkamil
as code owners
parostatkiem-zz
approved these changes
Nov 28, 2018
…o wrong, added example for this use case
…ew-with-queryparams
…preserveview-with-queryparams
jesusreal
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #249
I got the issue setup running locally to show this PR in action.
Alternatively you can play around with using
withParamandperserveViewin combination while going from FE1 to FE2 to FE1 which should create a chain of 3 preserved views.