Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved changes modal #252

Merged
merged 71 commits into from
Dec 18, 2018
Merged

Unsaved changes modal #252

merged 71 commits into from
Dec 18, 2018

Commits on Nov 22, 2018

  1. Modal interaction works

    @parostatkiem-zz
    parostatkiem-zz committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    6656a2b View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal

# Conflicts:
#	core/src/services/routing.js
    @parostatkiem-zz
    parostatkiem-zz committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    ccc8157 View commit details
    Browse the repository at this point in the history

  2. Implement the prompt

    @parostatkiem-zz
    parostatkiem-zz committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    a0c8f0e View commit details
    Browse the repository at this point in the history

  3. Improve code & add comments

    @parostatkiem-zz
    parostatkiem-zz committed Nov 23, 2018
    Configuration menu
    Copy the full SHA
    38afc97 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. Add support for custom title and text

    @parostatkiem-zz
    parostatkiem-zz committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    6670654 View commit details
    Browse the repository at this point in the history

  2. Fix obsolete import

    @parostatkiem-zz
    parostatkiem-zz committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    6b83b17 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    259a587 View commit details
    Browse the repository at this point in the history

  2. Handle potential errors

    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    19146ee View commit details
    Browse the repository at this point in the history

  3. Add unit test

    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    eb1a472 View commit details
    Browse the repository at this point in the history

  4. Add demo to Angular example & add e2e tests

    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    0f1f65e View commit details
    Browse the repository at this point in the history

  5. Update comment in e2e

    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    6c91d1d View commit details
    Browse the repository at this point in the history

  6. Undo temporary change

    @parostatkiem-zz
    parostatkiem-zz committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    d7b3b8b View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    1686dae View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    ae77b09 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Merge branch 'master' into Unsaved-changes-modal

    @jesusreal
    jesusreal authored Nov 29, 2018
    Configuration menu
    Copy the full SHA
    242c90f View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Remove unnecessary css imports

    @jesusreal
    jesusreal committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    87d0060 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal

# Conflicts:
#	core/src/services/routing.js
    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    84fc378 View commit details
    Browse the repository at this point in the history

  3. Add missing dependency

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    22779f3 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary changes

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    d3293e3 View commit details
    Browse the repository at this point in the history

  5. Refactor state structure in app.html

    @jesusreal
    jesusreal committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    4a51b86 View commit details
    Browse the repository at this point in the history

  6. extract checking if component is able to handle modal

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    8165408 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'Unsaved-changes-modal' of https://github.com/parostatki… 

    …em/luigi into Unsaved-changes-modal

# Conflicts:
#	core/src/services/routing.js
    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    488c767 View commit details
    Browse the repository at this point in the history

  8. shorten promise handling

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    70fd297 View commit details
    Browse the repository at this point in the history

  9. Remove obsolete changes

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    3c5820f View commit details
    Browse the repository at this point in the history

  10. Improve dirty page example in Angular app

    @parostatkiem-zz
    parostatkiem-zz committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    9de58aa View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Improve solution

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    46ceedd View commit details
    Browse the repository at this point in the history

  2. Improve history handling

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    4c7b559 View commit details
    Browse the repository at this point in the history

  3. Fix typo

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    ebf539c View commit details
    Browse the repository at this point in the history

  4. Add missing dependency

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    597f33f View commit details
    Browse the repository at this point in the history

  5. Improve e2e & use dedicated data-cy attribute

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    fa4943b View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary e2e comment

    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    13bcf62 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    5852ca4 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal

# Conflicts:
#	core/src/App.html
    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    216c667 View commit details
    Browse the repository at this point in the history

  2. Remove obsolete comment

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    0c014fe View commit details
    Browse the repository at this point in the history

  3. rename 'changeDirtyStatus' method & generate proper docu

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    2bf41d9 View commit details
    Browse the repository at this point in the history

  4. Rename e2e tests

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1e51dfc View commit details
    Browse the repository at this point in the history

  5. Polish the language

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    04f046a View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary comment

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    9c5f6cb View commit details
    Browse the repository at this point in the history

  7. Center the modal when side nav is collapsed

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ad5b55d View commit details
    Browse the repository at this point in the history

  8. center the modal in the iframe

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    9e698c9 View commit details
    Browse the repository at this point in the history

  9. Improve modal responsiveness with side Nav

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    eecd8a1 View commit details
    Browse the repository at this point in the history

  10. Remove unwanted history entry when user declines redirecting

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    a690e56 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    131bf8c View commit details
    Browse the repository at this point in the history

  12. Avoid unwanted history entry when redirecting

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    7806a56 View commit details
    Browse the repository at this point in the history

  13. Remove unnecessary example from docu

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    07fe6e6 View commit details
    Browse the repository at this point in the history

  14. Focus "Yes" button on modal

    @parostatkiem-zz
    parostatkiem-zz committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    ac311a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    77b76c7 View commit details
    Browse the repository at this point in the history

  2. Improve modal positioning

    @parostatkiem-zz
    parostatkiem-zz committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    8997828 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Merge branch 'master' of https://github.com/kyma-project/luigi into U… 

    …nsaved-changes-modal
    @parostatkiem-zz
    parostatkiem-zz committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    dbdd6d2 View commit details
    Browse the repository at this point in the history

  2. Improve responsiveness

    @parostatkiem-zz
    parostatkiem-zz committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    47673ed View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Update unsaved changes modal trigger to support external links on top… 

    … and left nav
    @jesusreal
    jesusreal committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    8d1d9fa View commit details
    Browse the repository at this point in the history

  2. Support unsaved changes modal trigger on logout

    @jesusreal
    jesusreal committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    3885d0b View commit details
    Browse the repository at this point in the history

  3. Refactorings to minimize code duplication

    @jesusreal
    jesusreal committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    ae830d0 View commit details
    Browse the repository at this point in the history

  4. Add error handler for showUnsavedChangesModal on handleRouteClick mehtod

    @jesusreal
    jesusreal committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    ff6f493 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2018

  1. For navigation from luigi client, apply unsaved changes logic without… 

    … browser history manipulation
    @jesusreal
    jesusreal committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    71c8798 View commit details
    Browse the repository at this point in the history

  2. Avoid needing to click twice in the modal when clicking history back … 

    …and then No in the modal
    @jesusreal
    jesusreal committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    402f60e View commit details
    Browse the repository at this point in the history

  3. Fix unit tests

    @jesusreal
    jesusreal committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    583356e View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into Unsaved-changes-m… 

    …odal

# Conflicts:
#	core/src/services/routing.js
    @jesusreal
    jesusreal committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    d00da70 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/master' into Unsaved-changes-m… 

    …odal
    @jesusreal
    jesusreal committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    2446b8f View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2018

  1. Support unsaved changes modal for preserved views

    @jesusreal
    jesusreal committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    7e658c8 View commit details
    Browse the repository at this point in the history

  2. Add backdrop to unsaved changes modal

    @jesusreal
    jesusreal committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    cb010e2 View commit details
    Browse the repository at this point in the history

  3. Refactor by removing inside app navigation handler

    @jesusreal
    jesusreal committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    8ee233c View commit details
    Browse the repository at this point in the history

  4. Undo unimportant cosmetic changes to avoid massive merge conflicts wi… 

    …th other tasks in progress
    @jesusreal
    jesusreal committed Dec 14, 2018
    Configuration menu
    Copy the full SHA
    ba7cd48 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into Unsaved-changes-modal

    @jesusreal
    jesusreal authored Dec 14, 2018
    Configuration menu
    Copy the full SHA
    2022b6d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Add unsaved modal changes support and pointer cursor to logo title co… 

    …mponent
    @jesusreal
    jesusreal committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    efd78e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:kyma-project/luigi into Unsaved-c… 

    …hanges-modal

# Conflicts:
#	core/src/App.html
#	core/src/Authorization.html
#	core/src/navigation/LeftNav.html
#	core/src/navigation/TopNav.html
#	core/src/services/routing.js
#	core/src/utilities/helpers/generic-helpers.js
    @jesusreal
    jesusreal committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    1d35d3e View commit details
    Browse the repository at this point in the history

  3. Fix e2e tests

    @jesusreal
    jesusreal committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    2bd5f2e View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. small improvement in luigi client docu

    @jesusreal
    jesusreal committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    5cb0ebb View commit details
    Browse the repository at this point in the history

  2. More docu changes

    @jesusreal
    jesusreal committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    a82ae71 View commit details
    Browse the repository at this point in the history

  3. improve docu for text added on last commit

    @jesusreal
    jesusreal committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    e128b07 View commit details
    Browse the repository at this point in the history

  4. Update description for isDirty parameter

    @jesusreal
    jesusreal committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    7d7cdf4 View commit details
    Browse the repository at this point in the history