Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url anchor support for micro frontends #2599

Merged
merged 18 commits into from
Mar 14, 2022

Conversation

stanleychh
Copy link
Contributor

Description
Introduce two functions at LuigiClient

  1. getAnchor()

Path is http://some.url.de#myAnchor
LuigiClient.getAnchor() return myAnchor

  1. setAnchor(String)

Path is http://some.url.de
LuigiClient.setAnchor('myAnchor)
The path becomes to http://some.url.de#myAnchor

Related issue(s)
Fixes ##2433

@stanleychh stanleychh added the enhancement New feature or request label Mar 1, 2022
@ndricimrr ndricimrr self-assigned this Mar 7, 2022
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@stanleychh stanleychh merged commit 2478386 into SAP:master Mar 14, 2022
@stanleychh stanleychh deleted the 2433-url-anchor branch March 14, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants