Implement tests by using luigi mock module #2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment-tests-by-using-LuigiMockModule
…ment-tests-by-using-LuigiMockModule
…ment-tests-by-using-LuigiMockModule
…ment-tests-by-using-LuigiMockModule
viktorsperling
requested review from
alexandra-simeonova,
hardl,
JohannesDoberer,
ndricimrr,
stanleychh,
wdoberschuetz and
rafalgamon
as code owners
…ment-tests-by-using-LuigiMockModule
…b.com:SAP/luigi into 2112-implement-tests-by-using-LuigiMockModule
…b.com:SAP/luigi into 2112-implement-tests-by-using-LuigiMockModule
ndricimrr
changed the title
ndricimrr
reviewed
Sep 8, 2022
| @@ -1,172 +1,14 @@ | |||
| import { APP_INITIALIZER, NgModule } from '@angular/core'; | |||
| import { LuigiMockEngine } from '../../../../../../testing-utilities/dist/'; | |||
There was a problem hiding this comment.
import { LuigiMockEngine } from '@luigi-project/testing-utilities';
add this later. keep duplicate temporarily below
…b.com:SAP/luigi into 2112-implement-tests-by-using-LuigiMockModule
wdoberschuetz
approved these changes
Sep 27, 2022
client-frameworks-support/testing-utilities/test/cypress/fixtures/example.json
Outdated
Show resolved
Hide resolved
rafalgamon
approved these changes
Sep 27, 2022
ndricimrr
reviewed
Sep 28, 2022
| @@ -1,16 +1,17 @@ | |||
| import { APP_INITIALIZER, NgModule } from '@angular/core'; | |||
| // TODO: Use MockEngine directly from the package after released | |||
| // import { LuigiMockEngine } from '@luigi-project/testing-utilities'; | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#2112