Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external link option for IBN #2941

Merged
merged 20 commits into from
Nov 3, 2022

Conversation

ndricimrr
Copy link
Contributor

@ndricimrr ndricimrr commented Oct 21, 2022

Description

Changes proposed in this pull request:

  • Adds possibility to define external links for intent navigation

So for intentMapping config:

 {
      semanticObject: 'External',
      action: 'view',
      externalLink: { url: 'https://www.sap.com', openInNewTab: true }
}

The following should navigate to sap.com in a new tab:

LuigiClient.linkManager().navigateToIntent('External-view')
LuigiClient.linkManager().navigate('/#?intent=External-view')
Luigi.navigation().navigate('/#?intent=External-view')

Related issue(s)

Fixes #2936

@ndricimrr ndricimrr added the enhancement New feature or request label Oct 21, 2022
@ndricimrr ndricimrr force-pushed the 2936-intent-based-navigation-external-link branch from b914eb8 to f5ce332 Compare October 25, 2022 11:07
core/src/App.svelte Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer self-assigned this Oct 28, 2022
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndricimrr ndricimrr merged commit facf8e5 into master Nov 3, 2022
@ndricimrr ndricimrr deleted the 2936-intent-based-navigation-external-link branch November 3, 2022 14:54
This was referenced Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intent based navigation for external links
3 participants