LuigiClient type declaration for web components #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Bitte geben Sie eine Commit-Beschreibung ein, um zu erklären, warum dieser # Merge erforderlich ist, insbesondere wenn es einen aktualisierten # Upstream-Branch mit einem Thema-Branch zusammenführt. # # Zeilen, die mit '#' beginnen, werden ignoriert, # und eine leere Beschreibung bricht den Commit ab.
JohannesDoberer
requested review from
alexandra-simeonova,
hardl,
ndricimrr,
wdoberschuetz and
rafalgamon
as code owners
wdoberschuetz
approved these changes
Dec 6, 2022
client/luigi-element.d.ts
Outdated
| collapse: () => void; | ||
| expand: () => void; | ||
| setSize: (value: number) => void; | ||
| on: (key: SplitViewEvents, callback: () => void) => string; // |
There was a problem hiding this comment.
You can remove the // :).
client/luigi-element.d.ts
Outdated
| * @param {String} literal The literal to process. | ||
| * @returns {String} Returns the processed literal. | ||
| */ | ||
| export declare const html: (strings: TemplateStringsArray, ...values: unknown[]) => string; |
There was a problem hiding this comment.
(question) In the luigi-element.js this method receives keys luigi-element.js: L148. But it's declared as values here. Should it be like this? Maybe I'm overeager but there's no param for this as well. I presume it's all by design, if so, ignore my comment. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.