-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unsaved changes modal not closing after browser back #2984
Conversation
Needs clarification: |
decided to keep modal open on browser back (indirectly.). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Description
When going back the handling is done but the dirty bit is not set back to false leading into 'endless loop' where the modal is re-created again and again after clicking yes.
Changes proposed in this pull request:
Related issue(s)
Fixes #2964