Fix dropdowns behavior on click events

[dariadomagala-sap]

Description

Changes proposed in this pull request:

• Fix dropdowns behavior on click events

Related issue(s)

[jesusreal]

LGTM

[pekura]

It still does not work perfectly - in chrome when you click on a bottom part of the entry (somewhere in the last quarter of the highlighted area, below the text) it does not get activated - in the context chooser as well as the Logout button. In firefox the context chooser works fine but the Logout button has the same problem as in chrome.

[jesusreal]

It works well. I have a couple of refactoring suggenstions, please see my comments.

There are some refactorings I would definitely apply to the logic related to dropdowns, but this is out of scope for this task, we might do it in a different task. This is what I would change:

• Context switcher should just read and not write the dropdownStates object and instead fire an event to topNav component, since it is not responsibility of context switcher to do that and we are duplicating some methods, more precisely closeAllDropdowns, toggleDropdownState and dropDownStatesNegated.
• Have dropdown states as booleans and not as strings
• Remove dropDownStatesNegated method
• DropdownStates properties should be cased consistently with the rest of the code base (thisWay and not THAT_WAY)

[jesusreal]

I would refactor this method, also in ContextSwitcher component, to the following:

closeAllDropdowns() {
  const dropDownStates = this.get().dropDownStates || {};
  Object.keys(dropDownStates).forEach(k => { dropDownStates[k] = 'false' });
  this.set({dropDownStates});
}

[dariadomagala-sap]

dropDownStates is an empty object at the beginning. Adding the foreach loop without checking if the array of keys is not empty, would cause errors.

[jesusreal]

Not something you introduced, but {dropDownStates} is not needed here.

[jesusreal]

As it is working as required and you are working next week and I will be on vacation, I am approving it now. Please still consider my refactoring suggestions before merging.