Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip for categories expand collapse button #3013

Merged
merged 17 commits into from
Dec 6, 2022
Merged

Tooltip for categories expand collapse button #3013

merged 17 commits into from
Dec 6, 2022
+253 −151

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3007

Added two properties to the category object

category:{
...
titleExpandButton: 'Expand this category',
titleCollapseButton: 'Collapse this category'
}

@JohannesDoberer JohannesDoberer added A11Y Accessibility enhancement New feature or request documentation documentation tasks and removed A11Y Accessibility labels Nov 28, 2022
@wdoberschuetz wdoberschuetz self-assigned this Nov 30, 2022
wdoberschuetz
wdoberschuetz approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@wdoberschuetz wdoberschuetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer merged commit 99642f5 into master Dec 6, 2022
@JohannesDoberer JohannesDoberer deleted the tooltip-for-category-expand-collapse-button branch December 6, 2022 14:44
This was referenced Jan 16, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdoberschuetz wdoberschuetz wdoberschuetz approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@rafalgamon rafalgamon Awaiting requested review from rafalgamon

Assignees

@wdoberschuetz wdoberschuetz

Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing alt text for grouped nav nodes arrow
3 participants
@JohannesDoberer @wdoberschuetz @alexandra-simeonova