Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a listener via Luigi client API, call only the listener being added #305

Merged

Conversation

jesusreal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • When adding an init or context update listener via Luigi Client API, call only the listener being added.

Related issue(s)

Fixes https://github.com/kyma-project/console/issues/429

client/luigi-client.js Outdated Show resolved Hide resolved
@pekura pekura self-assigned this Dec 21, 2018
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus self-assigned this Dec 21, 2018
@maxmarkus maxmarkus added bug Something isn't working area/luigi labels Dec 21, 2018
@kwiatekus kwiatekus merged commit 349ba42 into SAP:master Dec 27, 2018
@kwiatekus kwiatekus deleted the luigi-client-add-new-listener-call-only-new branch December 27, 2018 12:06
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
…eing added (SAP#305)

* When adding an init or context update listener, call only the listener being added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants