Luigi config meets es6 #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/package.json
parostatkiem-zz
requested review from
antiheld,
bszwarc,
dariadomagala-sap,
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
maxmarkus,
pekura,
tomekpapiernik and
y-kkamil
as code owners
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.js
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.js
|
following new step-by-step Angular 6 guide results in a page with an error EDIT: the same goes for no-framework guide - Luigi tries to fetch extendedConfiguration.bundle.js, but it is not generated. Am I missing something? EDIT: nevermind, i must have done something wrong, it works now! |
y-kkamil
suggested changes
Jan 16, 2019
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.js
y-kkamil
approved these changes
Jan 17, 2019
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/package-lock.json
maxmarkus
approved these changes
Jan 18, 2019
…uigi-config-meets-ES6 # Conflicts: # core/examples/luigi-sample-angular/src/assets/extendedConfiguration.js
Co-Authored-By: parostatkiem <jansudczak@gmail.com>
bszwarc
approved these changes
Jan 21, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Create fully-functional es6 transpiling * Modularize config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important:
lerna bootstrapin luigi-sample-angular folder is necessary!If you would like to test setup commands or scripts, you have to replace for an obvious reason
with
Vue and OpenUI setup scripts will be fixed by #322, then immidiately updated by #341 to work with the changes from this PR.
Changes proposed in this pull request:
extendedConfiguration.jsusing ES6 + class properties and split it into few filesRelated issue(s)
#268
#323