Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css-fix: tabNav + breadcrumb #3152

Merged
merged 6 commits into from
Feb 10, 2023
Merged

Css-fix: tabNav + breadcrumb #3152

merged 6 commits into from
Feb 10, 2023
+24 −16

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3132

@JohannesDoberer JohannesDoberer marked this pull request as ready for review February 6, 2023 20:01
@ndricimrr ndricimrr self-assigned this Feb 6, 2023
ndricimrr
ndricimrr reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested and found no issues. One minor suggestion on the code

core/src/App.svelte Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer changed the base branch from master to main February 10, 2023 12:47
@JohannesDoberer JohannesDoberer changed the base branch from main to master February 10, 2023 12:47
@JohannesDoberer JohannesDoberer mentioned this pull request Feb 10, 2023
Closed
@JohannesDoberer JohannesDoberer merged commit 025c5ed into master Feb 10, 2023
@JohannesDoberer JohannesDoberer deleted the css-fix-tabNav-plus-breadcrumb branch February 10, 2023 12:50
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Feb 10, 2023
This was referenced Feb 10, 2023
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees

@ndricimrr ndricimrr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tabnav position /w breadcrumb
2 participants
@JohannesDoberer @ndricimrr