Improve defaultChildNode #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
kwiatekus,
maxmarkus,
pekura and
y-kkamil
as code owners
parostatkiem-zz
added
bug
pekura
suggested changes
Jan 7, 2019
pekura
approved these changes
Jan 7, 2019
y-kkamil
approved these changes
Jan 7, 2019
jesusreal
reviewed
Jan 7, 2019
| } else if (children && children.length > 0) { | ||
| return children[0].pathSegment; | ||
| } else if (children && children.length) { | ||
| const validChild = children.find( |
There was a problem hiding this comment.
Not reviewing it, but saw it and would like to give feedback. I would rewrite is as
const validChild = children.find(
child => child.pathSegment && (child.viewUrl || (child.externalLink && child.externalLink.url))
);
return validChild ? validChild.pathSegment : '';
Otherwise imo is like checking partially in the return statement if the validChild is valid, which doesn't make much sense
There was a problem hiding this comment.
I like it and I'll apply it 👍
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Improve defaultChildNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)