Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onLoad functionality for wc mfe #3352

Merged
merged 26 commits into from
Jul 31, 2023
Merged

onLoad functionality for wc mfe #3352

merged 26 commits into from
Jul 31, 2023

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Jul 14, 2023 •
edited by ndricimrr
Loading

Resolves #3344

@JohannesDoberer JohannesDoberer added enhancement New feature or request container labels Jul 14, 2023
@JohannesDoberer JohannesDoberer marked this pull request as ready for review July 17, 2023 07:07
@JohannesDoberer JohannesDoberer added the documentation documentation tasks label Jul 18, 2023
ndricimrr
ndricimrr approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JohannesDoberer JohannesDoberer added the WIP Work in progress label Jul 24, 2023
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label Jul 26, 2023
ndricimrr
ndricimrr reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some non-functional comments to maybe consider

container/test-app/test2.js Outdated Show resolved Hide resolved
container/test-app/test.js Outdated Show resolved Hide resolved
container/test-app/nested.js Outdated Show resolved Hide resolved
container/test-app/index.html Outdated Show resolved Hide resolved
container/public/LuigiCompoundContainer.svelte.d.ts Outdated Show resolved Hide resolved
JohannesDoberer and others added 6 commits July 27, 2023 14:52
@JohannesDoberer @ndricimrr
Update container/src/LuigiCompoundContainer.svelte
6a33655 
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
@JohannesDoberer @ndricimrr
Update container/src/LuigiContainer.svelte
336c9ed 
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
@JohannesDoberer
rename
6feb3a0
@JohannesDoberer
examples
8eee3e5
@JohannesDoberer @ndricimrr
Update container/test-app/test2.js
abd4b80 
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
@JohannesDoberer @ndricimrr
Update container/test-app/test.js
9274c85 
Co-authored-by: Ndricim Rrapi <ndricim.rrapi@sap.com>
@JohannesDoberer JohannesDoberer merged commit 2f80ab9 into main Jul 31, 2023
8 checks passed
@JohannesDoberer JohannesDoberer deleted the onLoad-functionality-container branch July 31, 2023 14:09
@JohannesDoberer JohannesDoberer changed the title onLoad functionality for mfe onLoad functionality for wc mfe Aug 23, 2023
@JohannesDoberer JohannesDoberer mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees
No one assigned
Labels
container documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container: "onload" event for mfe's
3 participants
@JohannesDoberer @ndricimrr @alexandra-simeonova