Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addNodeParams, getNodeParams and setAnchor for wc luigiClient #3389

Merged
merged 23 commits into from
Aug 18, 2023
Merged

addNodeParams, getNodeParams and setAnchor for wc luigiClient #3389

merged 23 commits into from
Aug 18, 2023

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer marked this pull request as ready for review August 10, 2023 09:25
@JohannesDoberer JohannesDoberer changed the title client api change signature of renderWebComponent addNodeParams, getNodeParams and setAnchor for wc luigiClient Aug 10, 2023
@JohannesDoberer JohannesDoberer added documentation documentation tasks enhancement New feature or request labels Aug 10, 2023
@ndricimrr ndricimrr self-assigned this Aug 10, 2023
ndricimrr
ndricimrr reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but while testing found some weird behavior in modal view

client/luigi-element.d.ts Show resolved Hide resolved
client/luigi-element.d.ts Show resolved Hide resolved
@JohannesDoberer JohannesDoberer added the WIP Work in progress label Aug 14, 2023
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label Aug 16, 2023
ndricimrr
ndricimrr approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested again and looks good

@JohannesDoberer JohannesDoberer merged commit 01114db into main Aug 18, 2023
11 checks passed
@JohannesDoberer JohannesDoberer deleted the extend-LuiguClientAPI-for-wc branch August 18, 2023 09:56
@JohannesDoberer JohannesDoberer mentioned this pull request Aug 23, 2023
Merged
This was referenced Jun 4, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandra-simeonova alexandra-simeonova alexandra-simeonova left review comments

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees

@ndricimrr ndricimrr

Labels
container documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohannesDoberer @ndricimrr @alexandra-simeonova