Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-testid attr to the close button for modal #3394

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Add data-testid attr to the close button for modal #3394

merged 5 commits into from
Aug 16, 2023

Conversation

JohannesDoberer
Copy link
Contributor

Fixes #3392

@JohannesDoberer JohannesDoberer marked this pull request as ready for review August 11, 2023 09:49
@JohannesDoberer JohannesDoberer added enhancement New feature or request documentation documentation tasks labels Aug 11, 2023
ndricimrr
ndricimrr approved these changes Aug 11, 2023
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@JohannesDoberer JohannesDoberer merged commit 00f5fc3 into main Aug 16, 2023
9 checks passed
@JohannesDoberer JohannesDoberer deleted the data-testid-for-modal-closebtn branch August 16, 2023 09:56
@JohannesDoberer JohannesDoberer mentioned this pull request Aug 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

Assignees
No one assigned
Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add data-testid to modal close button
3 participants
@JohannesDoberer @ndricimrr @alexandra-simeonova