-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload microfrontend when clicking on selected node #385
Conversation
This reverts commit ec5f47c.
…nsaved-changes-modal # Conflicts: # core/src/services/routing.js
…nsaved-changes-modal
# Conflicts: # client/luigi-client.js # core/examples/luigi-sample-angular/e2e/tests/luigi-client-features.spec.js # core/src/App.html # core/src/Authorization.html # core/src/ConfirmationModal.html # core/src/navigation/ContextSwitcher.html # core/src/navigation/LeftNav.html # core/src/navigation/TopNav.html # core/src/services/routing.js # core/src/utilities/helpers/generic-helpers.js # core/test/services/routing.spec.js # docs/luigi-client-api.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't that be possible to reload the content inside, without reloading whole iframe (in case of viewgroups)? When the app inside is bigger, switching between views back and forth (reusing the same iframe) is much faster than reloading the whole iframe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After our discussion - LGTM 🙂
I think it is not possible to trigger a content refresh only, so to keep the asses loaded. This would require eg. a Luigi Client listener, which needs a Thanks, we leave it like it is, as discussed :-D |
* triggering iframe reload when the same route is accessed again
Implemented reload of iframe without triggering spinner.