Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload microfrontend when clicking on selected node #385

Merged
merged 106 commits into from
Jan 31, 2019

Conversation

maxmarkus
Copy link
Contributor

Implemented reload of iframe without triggering spinner.

pekura and others added 30 commits August 6, 2018 13:56
This reverts commit ec5f47c.
…nsaved-changes-modal

# Conflicts:
#	core/src/services/routing.js
# Conflicts:
#	client/luigi-client.js
#	core/examples/luigi-sample-angular/e2e/tests/luigi-client-features.spec.js
#	core/src/App.html
#	core/src/Authorization.html
#	core/src/ConfirmationModal.html
#	core/src/navigation/ContextSwitcher.html
#	core/src/navigation/LeftNav.html
#	core/src/navigation/TopNav.html
#	core/src/services/routing.js
#	core/src/utilities/helpers/generic-helpers.js
#	core/test/services/routing.spec.js
#	docs/luigi-client-api.md
@maxmarkus maxmarkus changed the title Reload same node Reload microfrontend when clicking on selected node Jan 28, 2019
@dariadomagala-sap dariadomagala-sap self-assigned this Jan 28, 2019
Copy link
Contributor

@dariadomagala-sap dariadomagala-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't that be possible to reload the content inside, without reloading whole iframe (in case of viewgroups)? When the app inside is bigger, switching between views back and forth (reusing the same iframe) is much faster than reloading the whole iframe.

@JohannesDoberer JohannesDoberer self-assigned this Jan 29, 2019
Copy link
Contributor

@dariadomagala-sap dariadomagala-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After our discussion - LGTM 🙂

@maxmarkus
Copy link
Contributor Author

maxmarkus commented Jan 29, 2019

I think it is not possible to trigger a content refresh only, so to keep the asses loaded. This would require eg. a Luigi Client listener, which needs a state update/route refresh mechanism implemented in every view for on microfrontend side. Guess this is over-complication. a plain location.refresh() does the same, and sources are cached locally anyway.

Thanks, we leave it like it is, as discussed :-D

@maxmarkus maxmarkus merged commit 1cc1853 into SAP:master Jan 31, 2019
@maxmarkus maxmarkus deleted the reload-same-node branch January 31, 2019 11:07
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* triggering iframe reload when the same route is accessed again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants