E2e tests with both routing types #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parostatkiem-zz
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
marynaKhromova,
maxmarkus,
pekura and
y-kkamil
as code owners
pekura
approved these changes
Jan 29, 2019
…2e-tests-with-both-routing-types
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Introduce cy.expectPathToBe() command * Make tets working with hashRouting * Add isHashRoutingOn() * Remove unused import * create cy.expectSearchToBe()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI tests now work with both types of routing. The routing type is read dynamically from
window.Luigi...useHashRoutingproperty.Changes proposed in this pull request:
cy.expectPathToBe()and use it instead ofexpect(loc.pathname).to.eq(...)isHashRoutingEnabled()helper function to do the check manually in special cases (like location.search in one of the tests)