-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add publishEvent documentation and tests #3882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's good as is, an alternative for publish event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I thought that would be bit of a stretch so thank you for trying :).
A general Question, in the comments there are references to filenames Like wcWebcomponent.js, is it for illustration or is it a reference to another example/sample? |
wcComponent.js , firstChild.js , etc are just random file names I chose for the example as illustration. |
Description
Changes proposed in this pull request:
Related issue(s)
Fixes #3860
Preview of docu section example: