Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds skipInitCheck property to LuigiCompoundContainer #3939

Merged
merged 15 commits into from
Oct 1, 2024

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds skipInitCheck property to LuigiCompoundContainer
  • adds related e2e test

Related issue(s)

Resolves #3929

@ndricimrr ndricimrr self-assigned this Sep 24, 2024
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some small comments

container/src/services/webcomponents.service.ts Outdated Show resolved Hide resolved
container/src/LuigiCompoundContainer.svelte Show resolved Hide resolved
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@walmazacn walmazacn merged commit 9488ccd into main Oct 1, 2024
12 checks passed
@walmazacn walmazacn deleted the 3929-skipinitcheck-property-in-luigicompoundcontainer branch October 1, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skipInitCheck property missing for LuigiCompoundContainer
3 participants