Adds nightly release task for container #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmazacn
requested review from
hardl,
JohannesDoberer,
ndricimrr,
VincentUllal,
smahati and
amilewskaa
as code owners
ndricimrr
reviewed
Sep 26, 2024
ndricimrr
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Seems like
process.env.NIGHTLY === true
needs to be
process.env.NIGHTLY === 'true' as env variables seem to be taken as strings instead.
Two other old cases in this file (scripts/tools/release-cli/release-cli.js) where NIGHTLY is being checked as boolean, so you may change those as well. They didn't do any harm till now, but was outputting wrong logs.
ndricimrr
reviewed
Sep 30, 2024
ndricimrr
approved these changes
Oct 1, 2024
ndricimrr
reviewed
Oct 2, 2024
|
Container nightly release was successful from this branch. Run went well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Resolves #3932