Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds option to disable luigiCookie #3946

Merged
merged 26 commits into from
Oct 2, 2024
Merged

Adds option to disable luigiCookie #3946

merged 26 commits into from
Oct 2, 2024

Conversation

walmazacn
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adds option to disable luigiCookie

Related issue(s)

Resolves #3942

@walmazacn walmazacn linked an issue Sep 24, 2024 that may be closed by this pull request
removal of luigiCookie #3942
Closed
@ndricimrr ndricimrr self-assigned this Sep 24, 2024
ndricimrr
ndricimrr reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments, but mainly discussion points for daily.

client/src/lifecycleManager.js Show resolved Hide resolved
container/src/services/container.service.ts Outdated Show resolved Hide resolved
ndricimrr
ndricimrr reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, but have some comments on Container code, that could be worth looking at.

container/src/services/container.service.ts Outdated Show resolved Hide resolved
container/test/services/container.service.spec.ts Show resolved Hide resolved
ndricimrr
ndricimrr reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only some small comments

docs/general-settings.md Outdated Show resolved Hide resolved
container/test-app/iframe/iframe-cookies.html Outdated Show resolved Hide resolved
walmazacn and others added 2 commits September 30, 2024 13:23
@walmazacn @ndricimrr
Update docs/general-settings.md
82ae9da 
Co-authored-by: Ndricim <ndricim.rrapi@sap.com>
@walmazacn @ndricimrr
Update container/test-app/iframe/iframe-cookies.html
20758bd 
Co-authored-by: Ndricim <ndricim.rrapi@sap.com>
ndricimrr
ndricimrr approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and looks good.

@ndricimrr ndricimrr added the enhancement New feature or request label Oct 2, 2024
@walmazacn walmazacn merged commit 8c977f0 into main Oct 2, 2024
11 checks passed
@walmazacn walmazacn deleted the 3942-option-to-disable-luigicookie branch October 2, 2024 08:49
@JohannesDoberer JohannesDoberer mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndricimrr ndricimrr ndricimrr approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@ndricimrr ndricimrr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

removal of luigiCookie
2 participants
@walmazacn @ndricimrr