-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic alert #395
Merged
Merged
Add generic alert #395
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
21a80fc
First working implementation
jesusreal ee1a41d
Add example for alerts and refactor html for project details page
jesusreal 8d2090c
Fix e2e tests
jesusreal 266cc4f
Remove two pieces of unneeded code in e2e tests
jesusreal cb6c070
Add links and sanitation to alert text
jesusreal 10a9781
More consistency among confirmation modal and alert implementations
jesusreal b396c1a
support relative paths in links
jesusreal 098a1a0
remove time-to-live from initial alert implementation in luigi core
jesusreal 3026048
Update luigi client docu for alert
jesusreal 2758b6b
Sanitize also if alert contains no links
jesusreal a25d8a4
use overflow-wrap instead of word-wrap in confirmation modal component
jesusreal c847521
e2e tests for alert - in progress
jesusreal b48ffc3
improve implementation of links in modals
jesusreal ffc5964
write e2e tests for generic alert - final
jesusreal deb1146
Remove timeout for creation of click listeners
jesusreal a3bb8b1
Fix issue for alerts without links
jesusreal e48cf4d
Remove export of function, since it is not used outside
jesusreal c12f789
More consistency on luigi ux messages
jesusreal d6153b6
Make dismiss button in generic alert mandatory. It was optional before.
jesusreal 62476c5
Explicitly update fiori-fundamentals dependency to latest and update …
jesusreal beef9d4
fix failing e2e test
jesusreal 314d607
Fix info alert class by adding map for alert type
jesusreal 3934a1c
Override background color for information alert to avoid transparency
jesusreal 9ce0397
Update client/src/luigi-client.js
dariadomagala-sap c199087
Update core/src/Alert.html
dariadomagala-sap 2bed735
Fixes for github ui commits
jesusreal 2103205
Update Luigi client docu
jesusreal 958532f
Fix default text not being displayed when not text field is provided
jesusreal e7fd6aa
Merge remote-tracking branch 'upstream/master' into add-generic-alert
jesusreal 3b46a80
bring back time-to-live option for core alerts
jesusreal 2dae7c3
Fix e2e tests after last change
jesusreal 48d8e00
Remove default settings for alert and do not display alert if no text…
jesusreal 7f3b8ea
Update luigi client docu
jesusreal 052253d
small improvements in overview and project components in angular exam…
jesusreal 331a30b
Update client/src/luigi-client.js
bszwarc 169cdd3
Update client/src/luigi-client.js
bszwarc 5aaad95
Update client/src/luigi-client.js
bszwarc 82a0103
Update client/src/luigi-client.js
bszwarc 144ce83
Update client/src/luigi-client.js
bszwarc 2d1594e
Add loading indicator link to overview page
dariadomagala-sap 59add8c
Update luigi client docu
jesusreal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also add a possibility to hide the alert (for example if someone wants to hide it after the navigation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will discuss it internally and provide the best solution to let the programmer of the microfrontend close the alert without the user explicitly clicking the dismiss button of the alert.