-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logout flaky test #3965
base: main
Are you sure you want to change the base?
Fix logout flaky test #3965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the linked failed test is based on older test definition and template:
it('Logout and login again', () => {
cy.login('tets@email.com', 'tets');
//logout
cy.get('[data-testid="luigi-topnav-profile"]').click();
cy.contains('Sign Out').click();
cy.get('[data-testid="logout-headline"]').should('contain', 'You have successfully logged out');
cy.get('[data-testid="logout-message"]').should('contain', 'Sign in again to continue working on awesome things!');
cy.expectPathToBe('/logout.html');
//login again
cy.contains('Re-Login').click();
cy.expectPathToBe('/assets/auth-mock/login-mock.html', 5000);
cy.get('body').should('contain', 'Login to Luigi sample app');
cy.login('tets@email.com', 'tets');
})
Compare it with the latest version of this test (5000ms timeout shouldn't be there):
https://github.com/SAP/luigi/blob/main/test/e2e-test-application/cypress/e2e/tests/1-angular/login-flow-nav-dropdown.cy.js#L69
That's why I'd wait until more tests run and then we can draw some conclusions
Yes. True. It seems like we need to wait until next version after "2.16.0" gets released, to see it. |
wait for next release and reconsider this if still flaky |
Yet another attempt...
Seems like for some unexplicable reason the login function is not found.
So I removed it.
Check Test Video Recording here
Fixes #3884