Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fdToolLayout background-color #3968

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix fdToolLayout background-color #3968

merged 4 commits into from
Oct 2, 2024

Conversation

JohannesDoberer
Copy link
Contributor

@JohannesDoberer JohannesDoberer commented Oct 1, 2024 •
edited
Loading

Wrong background-color in horizon-evening theme when you apply horizon evening (and don't use fundamental-ngx).

walmazacn
walmazacn approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@walmazacn walmazacn self-assigned this Oct 2, 2024
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Oct 2, 2024
@JohannesDoberer JohannesDoberer merged commit 3f4f089 into main Oct 2, 2024
11 checks passed
@JohannesDoberer JohannesDoberer deleted the fdToolLayout-wrong-background-color branch October 2, 2024 11:27
@JohannesDoberer JohannesDoberer mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@walmazacn walmazacn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohannesDoberer @walmazacn