Add ts declaration file #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 19, 2019 09:40
y-kkamil
requested review from
antiheld,
dariadomagala-sap,
hardl,
jesusreal,
JohannesDoberer,
kwiatekus,
marynaKhromova,
maxmarkus,
parostatkiem-zz and
pekura
as code owners
jesusreal
suggested changes
Mar 19, 2019
parostatkiem-zz
approved these changes
Mar 20, 2019
|
I have changed the import style to use {} instead of default export, also added parentNavigationContext to Context interface and reordered functions in the declaration file. |
jesusreal
approved these changes
Mar 20, 2019
y-kkamil
requested review from
bszwarc,
kazydek,
klaudiagrz,
mmitoraj and
tomekpapiernik
as code owners
bszwarc
approved these changes
Mar 21, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Add typescript declaration for luigi client * Add typescript declaration for luigi client * Fix broken references for luigiClient * Update formatting * Remove index.d.ts * Update formatting * Fix broken groups view * Fix broken overview view * Reorder functions, change Context interface, remove moduleInterop * Change import style * Add some types to the existing codebase * Revert broken package.json * Update documentation after luigi-client changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fixes #418