-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transparent background in alerts #427
Fix transparent background in alerts #427
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of good work has been done here! 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved since bug is fixed. Anyway please consider updating to newest fiori fundamental version.
core/package.json
Outdated
@@ -15,7 +15,7 @@ | |||
"copy-webpack-plugin": "^4.5.2", | |||
"css-loader": "^0.28.11", | |||
"file-loader": "^2.0.0", | |||
"fiori-fundamentals": "^1.4.1", | |||
"fiori-fundamentals": "1.4.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version 1.4.5 has already been published. Any reason not to use that one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with 1.4.5 (also updated on angular example) and everything seems to be fine.
Description
Changes proposed in this pull request:
Related issue(s)