Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luigi Authentication Events #501

Merged
merged 39 commits into from
May 14, 2019
Merged

Luigi Authentication Events #501

merged 39 commits into from
May 14, 2019

Conversation

maxmarkus
Copy link
Contributor

@maxmarkus maxmarkus commented Apr 29, 2019 •
edited
Loading

Implemented and created documentation for authentication events:

auth: {
  events: {
    onAuthSuccessful: (settings, authData) => {},
    onAuthError: (settings, err) => {}
    onAuthExpired: (settings) => {},
    onLogout: (settings) => {}
  }
}

Refactored Luigi Core API out to single classes.

@maxmarkus maxmarkus added enhancement New feature or request area/luigi labels Apr 29, 2019
@maxmarkus maxmarkus added this to the Sprint_Swinka_12 milestone Apr 29, 2019
@maxmarkus
unit tests for some async and auth helpers
d2702a1
@maxmarkus
Merge remote-tracking branch 'upstream/master' into 440-luigi-auth-ev…
61f9b74 
…ents

# Conflicts:
#	core/examples/luigi-sample-angular/package-lock.json
#	core/src/App.html
#	core/src/Authorization.html
#	core/src/providers/auth/oAuth2ImplicitGrant.js
@maxmarkus
docu changes
18b3701
@maxmarkus
refactored applyFunctionPromisified
e08ddd7
@maxmarkus maxmarkus marked this pull request as ready for review April 29, 2019 13:17
@maxmarkus maxmarkus removed this from the Sprint_Swinka_12 milestone Apr 29, 2019
maxmarkus and others added 2 commits May 7, 2019 14:45
@maxmarkus
refactored executeConfigFnAsync to not fail on errors by default but …
b4338af 
…returning undefined, added parameter to throw the received error
@bszwarc @maxmarkus
Apply suggestions from code review
da486f2 
Co-Authored-By: maxmarkus <1720843+maxmarkus@users.noreply.github.com>
@maxmarkus maxmarkus dismissed bszwarc’s stale review May 7, 2019 13:41

Basia is in vacation, but approved the rest of it personally.

bszwarc
bszwarc suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments

docs/authorization-configuration.md Outdated Show resolved Hide resolved
maxmarkus and others added 2 commits May 8, 2019 09:57
@maxmarkus
cleaned duplicate markup
871e63d
@bszwarc @maxmarkus
Update docs/authorization-configuration.md
fea77e9 
Co-Authored-By: maxmarkus <1720843+maxmarkus@users.noreply.github.com>
marynaKhromova
marynaKhromova approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maxmarkus maxmarkus added the WIP Work in progress label May 9, 2019
@maxmarkus
Copy link
Contributor Author

maxmarkus commented May 9, 2019 •
edited
Loading

onAuthError is not working anymore due to some changes that got merged in. small refactoring upcoming.
onAuthSuccess should also respect return false;

@maxmarkus maxmarkus removed the WIP Work in progress label May 13, 2019
@maxmarkus maxmarkus merged commit 78ca905 into SAP:master May 14, 2019
@maxmarkus maxmarkus deleted the 440-luigi-auth-events branch May 14, 2019 13:27
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus
Luigi Authentication Events (SAP#501)
9494fb1 
onAuthExpired, onAuthError, onAuthSuccess, onLogout implemented and documented, documented custom auth provider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pekura pekura pekura approved these changes

@bszwarc bszwarc bszwarc approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@antiheld antiheld Awaiting requested review from antiheld

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@y-kkamil y-kkamil Awaiting requested review from y-kkamil

Assignees

@pekura pekura

@marynaKhromova marynaKhromova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint_0
Development

Successfully merging this pull request may close these issues.
4 participants
@maxmarkus @pekura @bszwarc @marynaKhromova