Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user pic to userinfo #504

Merged
merged 25 commits into from
May 6, 2019

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

docs/authorization-configuration.md Outdated Show resolved Hide resolved
docs/authorization-configuration.md Outdated Show resolved Hide resolved
@marynaKhromova marynaKhromova self-assigned this May 2, 2019
@parostatkiem-zz parostatkiem-zz self-assigned this May 2, 2019
Copy link
Contributor

@parostatkiem-zz parostatkiem-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works 😊 but needs some polish 😟.
The main issue is the fact that the picture (or a placeholder) is misaligned.
master:
image
PR:
image

docs/authorization-configuration.md Outdated Show resolved Hide resolved
core/src/navigation/TopNav.html Outdated Show resolved Hide resolved
core/src/Authorization.html Outdated Show resolved Hide resolved
@maxmarkus maxmarkus added area/luigi enhancement New feature or request labels May 2, 2019
@maxmarkus maxmarkus added this to the Sprint_Swinka_13 milestone May 2, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@JohannesDoberer JohannesDoberer merged commit 250deeb into SAP:master May 6, 2019
@JohannesDoberer JohannesDoberer deleted the add-user-pic-to-userinfo branch May 6, 2019 12:06
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants