Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache and reuse viewgroups frame #520

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
867e8c0
first try
JohannesDoberer Apr 24, 2019
0bbd020
Merge branch 'master' into POC-Cache-and-reuse-viewgroups-frame
JohannesDoberer Apr 24, 2019
b646101
Merge branch 'master' into POC-Cache-and-reuse-viewgroups-frame
JohannesDoberer Apr 24, 2019
cdc978c
tets
JohannesDoberer Apr 25, 2019
e26f3d4
isolated view fix
JohannesDoberer Apr 25, 2019
68643a1
Merge branch 'master' into POC-Cache-and-reuse-viewgroups-frame
JohannesDoberer Apr 26, 2019
220109c
no message
JohannesDoberer Apr 26, 2019
6212fcf
preservedView mechanism
JohannesDoberer Apr 29, 2019
281a562
backwards compatibility
JohannesDoberer Apr 29, 2019
d5ab8a2
iframe spec fix
JohannesDoberer Apr 30, 2019
ce4f475
Merge branch 'master' into POC-Cache-and-reuse-viewgroups-frame
JohannesDoberer May 2, 2019
f159ff3
fix
pekura May 2, 2019
5ed7d78
tets
JohannesDoberer May 3, 2019
c0f6b24
no message
JohannesDoberer May 3, 2019
d56d72f
tets
JohannesDoberer May 8, 2019
209b2b1
no message
JohannesDoberer May 8, 2019
984f112
viewGroupSettings
JohannesDoberer May 9, 2019
8a3a971
added preload url handling
pekura May 9, 2019
537d3bf
fix for node refresh; not caching for non-ceacheable vgs
pekura May 9, 2019
1a7cdf4
tets
JohannesDoberer May 10, 2019
9c4c5b5
same route navigation fix
pekura May 10, 2019
5818016
Merge branch 'master' into POC-Cache-and-reuse-viewgroups-frame
JohannesDoberer May 10, 2019
0db1d87
loading indicator bugfix
pekura May 10, 2019
d7ea263
getAllViewGroupSEttings
JohannesDoberer May 10, 2019
d84f55f
Merge branch 'POC-Cache-and-reuse-viewgroups-frame' of github.com:Joh…
JohannesDoberer May 10, 2019
a473ba4
node refresh optimization
pekura May 10, 2019
e68a303
cleanup
pekura May 10, 2019
671fe44
cleanup
pekura May 10, 2019
fe3482e
cleanup
pekura May 10, 2019
f656c1e
cleanup
pekura May 10, 2019
5f3828c
new time
JohannesDoberer May 10, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
643 changes: 336 additions & 307 deletions core/examples/luigi-sample-angular/package-lock.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ class Navigation {
pathSegment: 'settings',
label: 'Settings',
viewUrl: '/sampleapp.html#/settings',
icon: 'settings'
icon: 'settings',
viewGroup: 'tets'
},
{
label: 'Open Google in this tab',
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

118 changes: 57 additions & 61 deletions core/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 4 additions & 5 deletions core/src/App.html
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
};

const addPreserveView = (component, data, config) => {
if (data.params.preserveView) {
if (data.params.preserveView || data.params.viewgroup) {
const {
preservedViews,
currentNode,
Expand All @@ -159,9 +159,8 @@
context
});
component.set({ preservedViews });
// Resetting iframe config to null, since Routing.navigateTo will then create a new iframe
// instead of using the existing instance for route.
config.iframe = null;
//mark iframe with pv if there is a preserved view situation
config.iframe['pv'] = 'pv';
}
};

Expand Down Expand Up @@ -536,7 +535,7 @@
handleNavClick(node) {
document.body.classList.remove('lui-leftNavToggle');
this.getUnsavedChangesModalPromise().then(() => {
Routing.handleRouteClick(node, this.get());
Routing.handleRouteClick(node, this);
});
},
handleModalResult(result) {
Expand Down
2 changes: 1 addition & 1 deletion core/src/services/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as GenericHelpers from '../utilities/helpers/generic-helpers';
class LuigiConfigManager {
constructor() {
this.configReadyTimeout = {
valueMs: 2000,
valueMs: 65000,
id: undefined
};

Expand Down
Loading