Error message for invalid auth provider #528
Merged
+32
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmarkus
requested review from
hardl,
jesusreal,
JohannesDoberer,
marynaKhromova and
pekura
as code owners
jesusreal
suggested changes
May 20, 2019
core/src/Authorization.html
Outdated
| `Could not instantate ${idpProviderName} provider : ${err}` | ||
| ); | ||
| const errorMsg = `Error: ${err.message || err}`; | ||
| console.error(errorMsg, err); |
There was a problem hiding this comment.
I think this can be just console.error(errorMsg);
There was a problem hiding this comment.
This part is inside an if block:
if (GenericHelpers.isPromise(idpProviderInstance)) {
Looks like we will not display the error if the idpProviderInstance is not a promise.
There was a problem hiding this comment.
I updated the implementation to output the second err (object) only in case there is a message found.
If the Provider does not return a Promise, it is up to the provider itself to throw any required error.
…rovider-error # Conflicts: # core/src/core-api/config.js
…case there is a message found.
jesusreal
approved these changes
May 22, 2019
JohannesDoberer
approved these changes
May 22, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* simplified auth check, added error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #510