Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug by overwriting description only when present #558

Conversation

jesusreal
Copy link
Contributor

How to test: set expiresIn variable in login-mock.html to for example 20 seconds

@maxmarkus maxmarkus self-assigned this May 28, 2019
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maxmarkus maxmarkus added the bug Something isn't working label May 28, 2019
@jesusreal jesusreal merged commit 43afcf0 into SAP:master May 28, 2019
@jesusreal jesusreal deleted the Token_expired_description_is_null_in_angular_example_app branch May 28, 2019 07:25
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants