Improve default child mechanism #610
Conversation
…lt-child-mechanism
maxmarkus
requested review from
hardl,
jesusreal,
JohannesDoberer,
marynaKhromova and
pekura
as code owners
…lt-child-mechanism # Conflicts: # core/test/services/routing.spec.js
core/test/services/routing.spec.js
Outdated
| @@ -467,6 +471,7 @@ describe('Routing', () => { | |||
|
|
|||
| assert.equal(singleStateWithPath.path, expectedRoute); | |||
| assert.equal(pushStateCallsNum + 1, expectedPushStateCallsNum); | |||
| assert.equal(replaceStateCallsNum, 0, 'replaceState not been called'); | |||
There was a problem hiding this comment.
Is it possible to use here notCalled as above and then we don't need the extra variable?
| assert.isFalse(NavigationHelpers.isNodeAccessPermitted(checkNode)); | ||
| }); | ||
|
|
||
| it('logged out, exclusive anonymousAccess', () => { |
There was a problem hiding this comment.
Please update the mocks for this tests, as they are the same as in the test above
There was a problem hiding this comment.
Done, we need to check if the exclusive anonymous access implementation is valid, since it also calls the permission checker function.
There was a problem hiding this comment.
Please bring this topic to the next Scrum meeting ;)
…arkus/luigi into 216-improve-default-child-mechanism
| assert.isTrue(NavigationHelpers.isNodeAccessPermitted(checkNode)); | ||
| }); | ||
|
|
||
| it('logged out, exclusive anonymousAccess, with permissionCheckerFn', () => { |
There was a problem hiding this comment.
This test is confusing IMHO since the mock of the function call returns false value, which is explicitly being returned above. It is also a little bit too much testing from my point of view. I would replace it with a test for the part where we are actually returning false, most precisely for the 2nd condition of the if block.
…arkus/luigi into 216-improve-default-child-mechanism
* improved default child mechanism and added e2e tets for it
You can now click on Browser back button to go to the last node, even if you were redirected by default child mechanism.