I18n manage current locale in luigi #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pekura
requested review from
bszwarc,
hardl,
jesusreal,
JohannesDoberer,
kazydek,
marynaKhromova,
maxmarkus,
mmitoraj and
tomekpapiernik
as code owners
jesusreal
suggested changes
Jul 15, 2019
pekura
commented
Jul 16, 2019
# Conflicts: # core/package.json # core/src/core-api/index.js # docs/luigi-core-api.md
bszwarc
suggested changes
Jul 18, 2019
client/luigi-client.d.ts
Outdated
| getCurrentLocale: () => string; | ||
|
|
||
| /** | ||
| * Sets current locale to the given one. |
There was a problem hiding this comment.
Suggested change
| * Sets current locale to the given one. | |
| * Sets current locale to the specified one. |
client/src/uxManager.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Sets current locale to the given one. |
There was a problem hiding this comment.
Suggested change
| * Sets current locale to the given one. | |
| * Sets current locale to the specified one. |
core/src/core-api/i18n.js
Outdated
| import { GenericHelpers } from '../utilities/helpers'; | ||
|
|
||
| /** | ||
| * Localization related functions. |
There was a problem hiding this comment.
Suggested change
| * Localization related functions. | |
| * Localization-related functions. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Sets current locale to the given one. |
There was a problem hiding this comment.
Suggested change
| * Sets current locale to the given one. | |
| * Sets current locale to the specified one. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Register a listener for locale changes |
There was a problem hiding this comment.
Suggested change
| * Register a listener for locale changes | |
| * Registers a listener for locale changes. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * De-register a listener for locale changes |
There was a problem hiding this comment.
Suggested change
| * De-register a listener for locale changes | |
| * Unregisters a listener for locale changes. |
core/src/core-api/i18n.js
Outdated
| import { GenericHelpers } from '../utilities/helpers'; | ||
|
|
||
| /** | ||
| * Localization related functions. |
There was a problem hiding this comment.
Suggested change
| * Localization related functions. | |
| * Localization-related functions. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Sets current locale to the given one. |
There was a problem hiding this comment.
Suggested change
| * Sets current locale to the given one. | |
| * Sets current locale to the specified one. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Register a listener for locale changes |
There was a problem hiding this comment.
Suggested change
| * Register a listener for locale changes | |
| * Registers a listener for locale changes. |
core/src/core-api/i18n.js
Outdated
| } | ||
|
|
||
| /** | ||
| * De-register a listener for locale changes |
There was a problem hiding this comment.
Suggested change
| * De-register a listener for locale changes | |
| * Unregisters a listener for locale changes. |
bszwarc
approved these changes
Jul 18, 2019
# Conflicts: # client/src/lifecycleManager.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.