Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alias fn for getEventData #639

Merged
merged 10 commits into from
Jul 12, 2019
Merged

alias fn for getEventData #639

merged 10 commits into from
Jul 12, 2019

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added the WIP Work in progress label Jul 9, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint_2 milestone Jul 9, 2019
@JohannesDoberer JohannesDoberer added enhancement New feature or request and removed WIP Work in progress labels Jul 9, 2019
@marynaKhromova marynaKhromova self-assigned this Jul 10, 2019
marynaKhromova
marynaKhromova approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@jesusreal jesusreal self-assigned this Jul 11, 2019
jesusreal
jesusreal approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving it, just a small suggestion in case you want to incorporate it ;)

client/luigi-client.d.ts Outdated Show resolved Hide resolved
bszwarc
bszwarc reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one formatting issue

docs/luigi-client-api.md Show resolved Hide resolved
@JohannesDoberer JohannesDoberer merged commit 8e0bb38 into SAP:master Jul 12, 2019
@JohannesDoberer JohannesDoberer deleted the alias-fn-for-getEventData branch July 12, 2019 14:45
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
alias fn for getEventData (SAP#639)
65b98ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusreal jesusreal jesusreal approved these changes

@bszwarc bszwarc bszwarc approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@pekura pekura Awaiting requested review from pekura

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@jesusreal jesusreal

@marynaKhromova marynaKhromova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint_2
Development

Successfully merging this pull request may close these issues.
4 participants
@JohannesDoberer @jesusreal @bszwarc @marynaKhromova