Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post message target handling in Luigi Client #651

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added enhancement New feature or request WIP Work in progress security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 labels Jul 12, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint_2 milestone Jul 12, 2019
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very short comment

README.md Outdated Show resolved Hide resolved
@JohannesDoberer JohannesDoberer removed the WIP Work in progress label Jul 16, 2019
@jesusreal jesusreal self-assigned this Jul 16, 2019
@JohannesDoberer JohannesDoberer changed the title 636 post message target handling in luigi client post message target handling in luigi client Jul 16, 2019
@jesusreal jesusreal changed the title post message target handling in luigi client Post message target handling in Luigi Client Jul 16, 2019
Copy link
Contributor

@jesusreal jesusreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Added my comments.

README.md Outdated Show resolved Hide resolved
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
client/src/helpers.js Show resolved Hide resolved
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
client/src/lifecycleManager.js Outdated Show resolved Hide resolved
* @private
*/
const _callAllFns = (objWithFns, payload) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that once this pr is merged we will need to update the changes done to this function.

@pekura pekura self-assigned this Jul 17, 2019
Co-Authored-By: Jesús Real Serrano <8238188+jesusreal@users.noreply.github.com>
@JohannesDoberer JohannesDoberer merged commit cbab3a9 into SAP:master Jul 19, 2019
@JohannesDoberer JohannesDoberer deleted the 636-postMessage-target-handling-in-LuigiClient branch July 19, 2019 12:46
@hardl hardl added the security always set in addition to specific security severity label, since github filtering is lacking OR label Feb 11, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security/medium Related to CVSSv3 security rating https://www.first.org/cvss/calculator/3.0 security always set in addition to specific security severity label, since github filtering is lacking OR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants