Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accumulated badge counter for mobile #664

Merged
merged 22 commits into from
Jul 26, 2019

Conversation

maxmarkus
Copy link
Contributor

Added badge counter for mobile nav button.

@JohannesDoberer JohannesDoberer self-assigned this Jul 23, 2019
@pekura pekura self-assigned this Jul 23, 2019
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in combination of #671) 👍

Copy link
Contributor

@pekura pekura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total count seems to be incorrect:

Bildschirmfoto 2019-07-23 um 10 43 37

@maxmarkus maxmarkus merged commit 1bdbdd7 into SAP:master Jul 26, 2019
@maxmarkus maxmarkus deleted the 657-accumulated-counter-mobile branch July 26, 2019 10:37
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* added support for mobile badge counter
* fixed wrong category badge count
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow up Follow up tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants