Navigation Node visibility with custom nodeAccessibilityResolver #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avigation without parent tree
maxmarkus
requested review from
antiheld and
dariadomagala-sap
as code owners
maxmarkus
requested review from
hardl,
jesusreal,
kazydek,
klaudiagrz,
kwiatekus,
pekura,
tomekpapiernik and
y-kkamil
as code owners
# Conflicts: # core/examples/luigi-sample-angular/package-lock.json # core/package-lock.json # core/test/routing.spec.js
maxmarkus
changed the title
maxmarkus
changed the title
maxmarkus
changed the title
dariadomagala-sap
suggested changes
Sep 11, 2018
dariadomagala-sap
approved these changes
Sep 12, 2018
kazydek
suggested changes
Sep 12, 2018
docs/navigation-configuration.md
Outdated
| @@ -58,6 +59,10 @@ window.Luigi.setConfig({ | |||
|
|
|||
| ### Navigation parameters | |||
|
|
|||
| - **nodeAccessibilityResolver** allows you to define a permission checker function that gets executed on every Node. If it returns false, the Node and it's children are removed from the navigation structure. You may want to add custom values to Nodes to receive it in the **nodeAccessibilityResolver** function. See [angular sampleconfig.js](../core/examples/luigi-sample-angular/src/assets/sampleconfig.js) for our constraints example. | |||
There was a problem hiding this comment.
- it's children ->
its children - it returns false ->
it returns `false` - preferably it would be great if you could replace the passive voice here with such a structure:
If it returns `false`, {subject} removes the Node and its children from the navigation structure. - You may want to add custom values to a Node to receive it in the nodeAccessibilityResolver function. ->
To receive a Node in the **nodeAccessibilityResolver** function, add custom values to it.(I hope the meaning is kept?) - for our constraints example. ->
for the **constraints** example.
docs/navigation-configuration.md
Outdated
| @@ -58,6 +59,10 @@ window.Luigi.setConfig({ | |||
|
|
|||
| ### Navigation parameters | |||
|
|
|||
| - **nodeAccessibilityResolver** allows you to define a permission checker function that gets executed on every Node. If it returns false, the Node and it's children are removed from the navigation structure. You may want to add custom values to Nodes to receive it in the **nodeAccessibilityResolver** function. See [angular sampleconfig.js](../core/examples/luigi-sample-angular/src/assets/sampleconfig.js) for our constraints example. | |||
|
|
|||
| ## Nodes | |||
There was a problem hiding this comment.
Yes, since this is a standalone feature while Nodes section is a collection of settings for a Node.
{
navigation: {
nodeAccessibilityResolver: someFunction,
nodes: [node1, node2] // every nodeN consists of parts described in ## Nodes
}
}
…arkus/luigi into feature/visibility-restriction-base
kazydek
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented
Luigi.config.navigation.nodeAccessibilityResolverfor checking Node access restrictionsRelated issue(s)
Fixes #44