Client permissions available in the client #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
bszwarc,
hardl,
jesusreal,
kazydek,
marynaKhromova,
maxmarkus,
mmitoraj,
pekura and
tomekpapiernik
as code owners
pekura
approved these changes
Jul 25, 2019
# Conflicts: # core/examples/luigi-sample-angular/src/app/project/project.component.ts # core/src/App.html # core/src/services/routing.js
bszwarc
reviewed
Jul 26, 2019
client/src/lifecycleManager.js
Outdated
| @@ -235,5 +235,14 @@ class LifecycleManager extends LuigiClientBase { | |||
| getPathParams() { | |||
| return this.currentContext.pathParams; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the current client permissions as specified on the navigation node. (See [Node parameters](navigation-parameters-reference.md).) | |||
There was a problem hiding this comment.
Suggested change
| * Returns the current client permissions as specified on the navigation node. (See [Node parameters](navigation-parameters-reference.md).) | |
| * Returns the current client permissions as specified in the navigation node. For details, see [Node parameters](navigation-parameters-reference.md). |
client/src/lifecycleManager.js
Outdated
|
|
||
| /** | ||
| * Returns the current client permissions as specified on the navigation node. (See [Node parameters](navigation-parameters-reference.md).) | ||
| * @returns {Object} client permissions as specified on the navigation node. |
There was a problem hiding this comment.
Suggested change
| * @returns {Object} client permissions as specified on the navigation node. | |
| * @returns {Object} client permissions as specified in the navigation node. |
jesusreal
reviewed
Jul 26, 2019
core/examples/luigi-sample-angular/src/luigi-config/extended/projectDetailNav.js
Show resolved
Hide resolved
core/examples/luigi-sample-angular/e2e/tests/luigi-client-ux-manager-features.spec.js
Show resolved
Hide resolved
…m:JohannesDoberer/luigi into clientPermissions-available-in-the-client
bszwarc
approved these changes
Jul 29, 2019
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
client permissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.