Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mechanism for partial luigi config update #752

Merged
merged 9 commits into from
Aug 22, 2019
Merged

Mechanism for partial luigi config update #752

merged 9 commits into from
Aug 22, 2019

Conversation

pekura
Copy link
Contributor

@pekura pekura commented Aug 19, 2019

No description provided.

@maxmarkus maxmarkus self-assigned this Aug 19, 2019
@maxmarkus maxmarkus added the enhancement New feature or request label Aug 19, 2019
maxmarkus
maxmarkus approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer self-assigned this Aug 21, 2019
JohannesDoberer
JohannesDoberer approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

bszwarc
bszwarc reviewed Aug 22, 2019
View reviewed changes
Copy link
Contributor

@bszwarc bszwarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments

core/src/core-api/config.js Outdated Show resolved Hide resolved
core/src/core-api/config.js Outdated Show resolved Hide resolved
pekura and others added 2 commits August 22, 2019 11:18
@pekura @bszwarc
Update core/src/core-api/config.js
6be58cf 
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
@pekura @bszwarc
Update core/src/core-api/config.js
09d1178 
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
@pekura pekura merged commit 8b25163 into SAP:master Aug 22, 2019
@pekura pekura deleted the mechanism-for-partial-Luigi-config-update branch August 22, 2019 09:36
@pekura pekura added this to the Sprint 4 milestone Aug 22, 2019
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@pekura
Mechanism for partial luigi config update (SAP#752)
6c09a03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@bszwarc bszwarc bszwarc approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@kazydek kazydek Awaiting requested review from kazydek

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.
4 participants
@pekura @maxmarkus @JohannesDoberer @bszwarc