Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UI tests attributes #790

Merged
merged 14 commits into from
Sep 4, 2019

Conversation

zarkosimic
Copy link
Contributor

Description

Changes proposed in this pull request:

  • data-e2e and data-cy replaced with data-testid

@CLAassistant
Copy link

CLAassistant commented Sep 2, 2019

CLA assistant check
All committers have signed the CLA.

@zarkosimic zarkosimic added the WIP Work in progress label Sep 2, 2019
@zarkosimic zarkosimic removed the WIP Work in progress label Sep 3, 2019
@JohannesDoberer JohannesDoberer self-assigned this Sep 3, 2019
@marynaKhromova marynaKhromova self-assigned this Sep 4, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@zarkosimic zarkosimic merged commit 259f58f into SAP:master Sep 4, 2019
@zarkosimic zarkosimic deleted the 765-replace-test-attributes branch September 4, 2019 14:26
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
* .DS_Store ignored

* Replace data-testid instead of data-cy

* Replace data-testid instead of data-e2e

* Revert .gitignore change

* Fix tests for topnav-category

* Fix tests for product-switcher

* Fix tests for topnav-dropdown

* Fix data-cy in tests

* Fix data-e2e in tests

* Replace data-testid with data-e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants