-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user menu without authorization #791
Merged
JohannesDoberer
merged 9 commits into
SAP:master
from
JohannesDoberer:user-menu-without-authorization
Sep 6, 2019
Merged
user menu without authorization #791
JohannesDoberer
merged 9 commits into
SAP:master
from
JohannesDoberer:user-menu-without-authorization
Sep 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohannesDoberer
requested review from
alexandra-simeonova,
bszwarc,
hardl,
jesusreal,
kazydek,
marynaKhromova,
maxmarkus,
mmitoraj,
pekura,
tomekpapiernik and
zarkosimic
as code owners
September 3, 2019 11:45
alexandra-simeonova
suggested changes
Sep 5, 2019
@@ -262,7 +262,7 @@ The profile section is a configurable drop-down list available in the top naviga | |||
- **externalLink** is an object which indicates that the node links to an external URL. If this parameter is defined, the **link** parameter is ignored. It has the following properties: | |||
- **sameWindow** defines if the external URL is opened in the current tab or in a new one. The default value for this parameter is `false`. | |||
- **url** is the external URL that the link leads to. | |||
|
|||
>**NOTE:** Either authorization nor profile property are configured the profile section in the top navigation bar is not visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
>**NOTE:** Either authorization nor profile property are configured the profile section in the top navigation bar is not visible. | |
>**NOTE:** Neither authorization nor profile property are configured if the profile section in the top navigation bar is not visible. |
alexandra-simeonova
approved these changes
Sep 5, 2019
…Doberer/luigi into user-menu-without-authorization
maxmarkus
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.