Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user menu without authorization #791

Merged

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added this to the Sprint 5 milestone Sep 3, 2019
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Sep 3, 2019
@@ -262,7 +262,7 @@ The profile section is a configurable drop-down list available in the top naviga
- **externalLink** is an object which indicates that the node links to an external URL. If this parameter is defined, the **link** parameter is ignored. It has the following properties:
- **sameWindow** defines if the external URL is opened in the current tab or in a new one. The default value for this parameter is `false`.
- **url** is the external URL that the link leads to.

>**NOTE:** Either authorization nor profile property are configured the profile section in the top navigation bar is not visible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
>**NOTE:** Either authorization nor profile property are configured the profile section in the top navigation bar is not visible.
>**NOTE:** Neither authorization nor profile property are configured if the profile section in the top navigation bar is not visible.

@alexandra-simeonova alexandra-simeonova self-assigned this Sep 5, 2019
@maxmarkus maxmarkus self-assigned this Sep 5, 2019
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesDoberer JohannesDoberer merged commit c17c080 into SAP:master Sep 6, 2019
@JohannesDoberer JohannesDoberer deleted the user-menu-without-authorization branch September 6, 2019 09:24
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants