Improve navigation-configuration.md #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandra-simeonova
requested review from
bszwarc,
kazydek,
mmitoraj and
tomekpapiernik
as code owners
alexandra-simeonova
requested review from
hardl,
marynaKhromova,
pekura,
JohannesDoberer and
maxmarkus
pekura
suggested changes
Sep 16, 2019
pekura
approved these changes
Sep 20, 2019
bszwarc
suggested changes
Sep 23, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Change based on Zarko's comments
Changed back to parameters based on Philipp's advice
bszwarc
reviewed
Sep 24, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
bszwarc
approved these changes
Sep 24, 2019
alexandra-simeonova
added a commit
that referenced
this pull request
Sep 30, 2019
This reverts commit 9c7ccd9.
stanleychh
pushed a commit
to stanleychh/luigi
that referenced
this pull request
Dec 30, 2021
* Improve navigation-configuration.md * Improvements based on suggestions * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Changes based on suggestions * small change * Changes based on suggestions Change based on Zarko's comments * Changed 'variables' to parameters Changed back to parameters based on Philipp's advice * Update docs/navigation-configuration.md * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com> * Update docs/navigation-configuration.md Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the Luigi /docs "navigation configuration" file
Changes proposed in this pull request:
Related issue(s)
See also: #766