Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue app auth error #834

Merged
merged 4 commits into from
Sep 24, 2019
Merged

Vue app auth error #834

merged 4 commits into from
Sep 24, 2019
+1,594 −1,624

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added the bug Something isn't working label Sep 16, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint 6 milestone Sep 16, 2019
@zarkosimic zarkosimic self-assigned this Sep 18, 2019
zarkosimic
zarkosimic approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@marynaKhromova marynaKhromova self-assigned this Sep 20, 2019
marynaKhromova
marynaKhromova approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@JohannesDoberer JohannesDoberer merged commit ed200bd into SAP:master Sep 24, 2019
@JohannesDoberer JohannesDoberer deleted the vue-app-auth-error branch September 24, 2019 09:21
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
vue app fix (SAP#834)
fadac43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zarkosimic zarkosimic zarkosimic approved these changes

@marynaKhromova marynaKhromova marynaKhromova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@jesusreal jesusreal Awaiting requested review from jesusreal

@maxmarkus maxmarkus Awaiting requested review from maxmarkus

@pekura pekura Awaiting requested review from pekura

Assignees

@zarkosimic zarkosimic

@marynaKhromova marynaKhromova

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohannesDoberer @zarkosimic @marynaKhromova