Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create getting started guide #836
Create getting started guide #836
Changes from 4 commits
915e4b9
c4a0b3f
f4a6aff
b447afa
b1bc5f8
a3c74e5
1601884
9f083c4
c897b2d
6222586
bea33b1
ed517d9
9869778
a3ae6e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would go with
end-to-end implementation
more thanapplication
- but it might be a preference :DThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, because otherwise we repeat "application" twice in the same sentence. 😃
I'm not sure about
This gives teams full autonomy over release dates and updates, at the same time reducing code dependencies.
There should be a word like "while" somewhere (a subordinating conjunction) because "at the same time reducing code dependencies" isn't a standalone sentence.Maybe just
This gives teams full autonomy over release dates and updates, and at the same time reduces code dependencies.
Or
This gives teams full autonomy over release dates and updates, while at the same time reducing code dependencies.
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right - I like the second one :) 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since "knowledge" is an uncountable noun, I don't think it needs an article 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually add an introductory line about the steps to follow :) It doesn't need to be "follow these steps" can be something similar. However, in this case, we have 2 steps - Setting up a Luigi core app + Reading docu. since the introduction says:
To create a global user interface and host a full web application in Luigi:
I was wondering if we may be more direct in the second step. For example, we can have:2. Configure the application. To do so, use the Luigi Core documentation. OR
2. Use the Luigi Core documentation to configure your application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above ⬆️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, maybe we can be more specific in the second point :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I made these changes in the latest commit.