Svelte 3 migration

core/examples/luigi-sample-angular/e2e/tests/luigi-client-link-manager-features.spec.js

@@ -91,49 +91,53 @@ describe('Luigi client linkManager', () => {
         cy.expectPathToBe('/projects/pr2');
       });
 
-      // check if path exists
-      cy.goToLinkManagerMethods($iframeBody);
-      [
-        // non-existent relative path
-        { path: 'projects/pr2/', successExpected: false },
-        // non-existent absolute path
-        { path: '/developers', successExpected: false },
-        // existent absolute path with '/' at the end
-        { path: '/projects/pr2/', successExpected: true },
-        // existent absolute path without '/' at the end
-        { path: '/projects/pr2', successExpected: true },
-        // existent path with two dynamic pathSegments
-        {
-          path: '/projects/pr1/users/groups/avengers/settings/dynamic-two',
-          successExpected: true
-        },
-        // existent relative path
-        { path: 'developers', successExpected: true }
-      ].map(data => {
-        const msgExpected = data.successExpected
-          ? `Path ${data.path} exists`
-          : `Path ${data.path} does not exist`;
-        const checkPathSelector = '.link-manager .check-path';
-        cy.wrap($iframeBody)
-          .find(checkPathSelector + ' input')
-          .clear()
-          .type(data.path);
+      cy.visitLoggedIn('/');
+
+      cy.getIframeBody().then($iframeBody => {
+        // check if path exists
+        cy.goToLinkManagerMethods($iframeBody);
+        [
+          // non-existent relative path
+          { path: 'projects/pr2/', successExpected: false },
+          // non-existent absolute path
+          { path: '/developers', successExpected: false },
+          // existent absolute path with '/' at the end
+          { path: '/projects/pr2/', successExpected: true },
+          // existent absolute path without '/' at the end
+          { path: '/projects/pr2', successExpected: true },
+          // existent path with two dynamic pathSegments
+          {
+            path: '/projects/pr1/users/groups/avengers/settings/dynamic-two',
+            successExpected: true
+          },
+          // existent relative path
+          { path: 'developers', successExpected: true }
+        ].map(data => {
+          const msgExpected = data.successExpected
+            ? `Path ${data.path} exists`
+            : `Path ${data.path} does not exist`;
+          const checkPathSelector = '.link-manager .check-path';
+          cy.wrap($iframeBody)
+            .find(checkPathSelector + ' input')
+            .clear()
+            .type(data.path);
+          cy.wrap($iframeBody)
+            .find(checkPathSelector + ' button')
+            .click();
+          cy.wrap($iframeBody)
+            .find(checkPathSelector + ' .check-path-result')
+            .contains(msgExpected);
+        });
+
+        // go back
+        cy.goToOverviewPage();
+        cy.goToLinkManagerMethods($iframeBody);
+        cy.expectPathToBe('/projects/pr2');
         cy.wrap($iframeBody)
-          .find(checkPathSelector + ' button')
+          .contains('go back: single iframe')
           .click();
-        cy.wrap($iframeBody)
-          .find(checkPathSelector + ' .check-path-result')
-          .contains(msgExpected);
+        cy.expectPathToBe('/overview');
       });
-
-      // go back
-      cy.goToOverviewPage();
-      cy.goToLinkManagerMethods($iframeBody);
-      cy.expectPathToBe('/projects/pr2');
-      cy.wrap($iframeBody)
-        .contains('go back: single iframe')
-        .click();
-      cy.expectPathToBe('/overview');
     });
   });
 

core/examples/luigi-sample-angular/src/luigi-config/extended/navigation.js

@@ -127,8 +127,12 @@ class Navigation {
     {
       category: { label: 'Messages', icon: 'lightbulb' },
       label: 'Errors',
+      pathSegment: 'errors',
       viewUrl: '/sampleapp.html#/projects/pr1/dynamic/errors',
       icon: 'alert',
+      context: {
+        label: 'Errors'
+      },
       badgeCounter: {
         label: 'Number of Errors',
         count: () => 2
@@ -137,8 +141,12 @@ class Navigation {
     {
       category: 'Messages',
       label: 'Warnings',
+      pathSegment: 'warnings',
       viewUrl: '/sampleapp.html#/projects/pr1/dynamic/warnings',
       icon: 'message-warning',
+      context: {
+        label: 'Warnings'
+      },
       badgeCounter: {
         label: 'Number of Warnings',
         count: () => 5
@@ -147,8 +155,12 @@ class Navigation {
     {
       category: 'Messages',
       label: 'Notifications',
+      pathSegment: 'notifications',
       viewUrl: '/sampleapp.html#/projects/pr1/dynamic/notifications',
       icon: 'ui-notifications',
+      context: {
+        label: 'Notifications'
+      },
       badgeCounter: {
         label: 'Number of Notifications',
         count: getMockBadgeCount