Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend iframe with "allow" attribute #845

Conversation

zarkosimic
Copy link
Contributor

Changes proposed in this pull request:

  • Add allow the attribute to the iframe
  • Add test regarding allow attribute on the iframe
  • Add an example in the documentation for general settings

@JohannesDoberer JohannesDoberer self-assigned this Sep 24, 2019
@marynaKhromova marynaKhromova self-assigned this Sep 26, 2019
Copy link
Contributor

@marynaKhromova marynaKhromova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@zarkosimic zarkosimic merged commit 3ca24c8 into SAP:master Sep 27, 2019
@zarkosimic zarkosimic deleted the 844_Iframe_feature_policy_allow_required_to_control branch September 27, 2019 12:56
@zarkosimic zarkosimic removed the documentation documentation tasks label Sep 27, 2019
@JohannesDoberer JohannesDoberer added this to the Sprint 6 milestone Oct 9, 2019
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants